Skip to content

Information label and bound value in CompareConverter sample don't match#1981

Merged
TheCodeTraveler merged 2 commits into
CommunityToolkit:mainfrom
GeorgeLeithead:Bug1980
Jul 15, 2024
Merged

Information label and bound value in CompareConverter sample don't match#1981
TheCodeTraveler merged 2 commits into
CommunityToolkit:mainfrom
GeorgeLeithead:Bug1980

Conversation

@GeorgeLeithead
Copy link
Copy Markdown
Contributor

@GeorgeLeithead GeorgeLeithead commented Jun 25, 2024

Description of Change

Changed the value of the Comparingvalue to be 50% of the Slider range, thus matching the label text. Not unit tests or documentation need to be updated.

Linked Issues

PR Checklist

Additional information

Tested on:

  • Windows 11
  • Android
  • iOS
  • Maccatalyst

@GeorgeLeithead
Copy link
Copy Markdown
Contributor Author

@bijington Do you want to review this?

@bijington
Copy link
Copy Markdown
Contributor

@bijington Do you want to review this?

Oh yes I do and I will try to next week 👍

@TheCodeTraveler TheCodeTraveler enabled auto-merge (squash) July 11, 2024 19:55
@GeorgeLeithead
Copy link
Copy Markdown
Contributor Author

Can someone with the appropriate permissions Re-Run this build? @brminnick

@TheCodeTraveler TheCodeTraveler merged commit cc1fb68 into CommunityToolkit:main Jul 15, 2024
@GeorgeLeithead GeorgeLeithead deleted the Bug1980 branch July 17, 2024 13:35
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Information label and bound value in CompareConverter sample don't match

3 participants