Fix Target Type Validation#2034
Merged
Merged
Conversation
TheCodeTraveler
commented
Jul 17, 2024
bijington
approved these changes
Jul 24, 2024
Contributor
bijington
left a comment
There was a problem hiding this comment.
Looks good to me @brminnick thanks for finishing this up. I just added the sample issue into the sample application as that was how I was testing this. I see you have a unit test covering it also though
This was
linked to
issues
Jul 25, 2024
|
Hey, when will the new version of MAUI toolkit come out? We need this fix as soon as we can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This fix updates the logic for
IsValidTargetType(Type, bool)to use thetargetTypeparameter passed into the method when verifying the nullable value types.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
I think this is the fix. But I'll defer to @bijington as the expert here since he added the nullable value type check in this PR: #1926
The exception being thrown in #2003 was caused by using MultiBindings where
TTomay not matchType targetType.