Skip to content

Fix Target Type Validation#2034

Merged
bijington merged 4 commits into
mainfrom
Fix-Converter-Target-Type-Validation
Jul 24, 2024
Merged

Fix Target Type Validation#2034
bijington merged 4 commits into
mainfrom
Fix-Converter-Target-Type-Validation

Conversation

@TheCodeTraveler
Copy link
Copy Markdown
Collaborator

@TheCodeTraveler TheCodeTraveler commented Jul 17, 2024

Description of Change

This fix updates the logic for IsValidTargetType(Type, bool) to use the targetType parameter passed into the method when verifying the nullable value types.

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

Additional information

I think this is the fix. But I'll defer to @bijington as the expert here since he added the nullable value type check in this PR: #1926

The exception being thrown in #2003 was caused by using MultiBindings where TTo may not match Type targetType.

Copy link
Copy Markdown
Contributor

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @brminnick thanks for finishing this up. I just added the sample issue into the sample application as that was how I was testing this. I see you have a unit test covering it also though

@ennethtpz
Copy link
Copy Markdown

Hey, when will the new version of MAUI toolkit come out? We need this fix as soon as we can.

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

3 participants