From aee27a069b9080110723e1172b43503fc7ef174f Mon Sep 17 00:00:00 2001 From: Ruben van der Linde Date: Sun, 19 Apr 2026 07:36:07 +0200 Subject: [PATCH] test: skip 5 AgendaServiceTest cases broken by ObjectService stub/real mismatch (#90) Same root cause as #91: when OpenRegister is installed the real ObjectService is autoloaded instead of the test stub, so mocked ::find and ::saveObject return types don't match the real signature. PR #91 covered Decision/Meeting/ Motion/Voting tests but missed AgendaServiceTest. Unskip once #90 is resolved. --- tests/Unit/Service/AgendaServiceTest.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/Unit/Service/AgendaServiceTest.php b/tests/Unit/Service/AgendaServiceTest.php index 29a82898..a0e4c12e 100644 --- a/tests/Unit/Service/AgendaServiceTest.php +++ b/tests/Unit/Service/AgendaServiceTest.php @@ -200,6 +200,8 @@ public function testPublishAgendaNotifiesOnlyActiveParticipants(): void */ public function testAdvanceBobPhaseCyclesThroughPhases(): void { + $this->markTestSkipped('See https://github.com/ConductionNL/decidesk/issues/90 — real ObjectService loads instead of stub.'); + $transitions = [ ['from' => 'voorstel', 'to' => 'beeldvorming'], ['from' => 'beeldvorming', 'to' => 'oordeelsvorming'], @@ -266,6 +268,8 @@ public function testAdvanceBobPhaseThrowsWhenItemNotFound(): void */ public function testAdvanceBobPhaseThrowsForInformationalItem(): void { + $this->markTestSkipped('See https://github.com/ConductionNL/decidesk/issues/90 — real ObjectService loads instead of stub.'); + $itemId = 'item-info'; $itemData = ['id' => $itemId, 'itemType' => 'informational', 'status' => 'beeldvorming']; @@ -290,6 +294,8 @@ public function testAdvanceBobPhaseThrowsForInformationalItem(): void */ public function testAdvanceBobPhaseThrowsAtFinalPhase(): void { + $this->markTestSkipped('See https://github.com/ConductionNL/decidesk/issues/90 — real ObjectService loads instead of stub.'); + $itemId = 'item-final'; $itemData = ['id' => $itemId, 'itemType' => 'decision', 'status' => 'afgerond']; @@ -318,6 +324,8 @@ public function testAdvanceBobPhaseThrowsAtFinalPhase(): void */ public function testProcessHamerstukkenUpdatesTaggedItemsOnly(): void { + $this->markTestSkipped('See https://github.com/ConductionNL/decidesk/issues/90 — real ObjectService loads instead of stub.'); + $meetingId = 'meeting-uuid-1'; $items = [ ['id' => 'item-1', 'title' => 'Item 1', 'tags' => ['hamerstuk'], 'status' => 'besluitvorming'], @@ -361,6 +369,8 @@ public function testProcessHamerstukkenUpdatesTaggedItemsOnly(): void */ public function testReorderItemsAssignsSequentialNumbers(): void { + $this->markTestSkipped('See https://github.com/ConductionNL/decidesk/issues/90 — real ObjectService loads instead of stub.'); + $meetingId = 'meeting-uuid-1'; $orderedIds = ['item-c', 'item-a', 'item-b'];