chore(quality): fix PHPCS inline IFs, named-param, alignment

Fixes lint violations surfaced while running composer phpcs + phpmd on
this branch:

- lib/Service/ItemService.php — inline IFs in extractOwner() rewritten
  as explicit if-blocks, extractOwner() call updated to use named
  parameter (ADR custom sniff: internal calls must use named params),
  docblock alignment tweak.
- lib/Controller/HealthController.php — pre-existing inline IFs in
  index() replaced with a guarded mutation pattern (sets degraded
  default, overrides on healthy) to also clear the PHPMD ElseExpression.
- lib/Controller/MetricsController.php — pre-existing equals-sign
  alignment between $prefix and $healthy.

`composer phpcs` + `composer phpmd` (minus a pre-existing BooleanArgumentFlag
warning on SettingsService::loadConfiguration($force) which would require
an API change) + `composer psalm` + `composer phpstan` are now clean.
`composer test:unit` still reports 26 / 26 passing.

Author: rubenvdlinde

lib/Controller/HealthController.php

@@ -76,8 +76,12 @@ public function index(): JSONResponse
     {
         try {
             $openRegister = $this->settingsService->isOpenRegisterAvailable();
-            $status       = ($openRegister === true) ? 'ok' : 'degraded';
-            $httpStatus   = ($openRegister === true) ? Http::STATUS_OK : Http::STATUS_SERVICE_UNAVAILABLE;
+            $status       = 'degraded';
+            $httpStatus   = Http::STATUS_SERVICE_UNAVAILABLE;
+            if ($openRegister === true) {
+                $status     = 'ok';
+                $httpStatus = Http::STATUS_OK;
+            }
 
             return new JSONResponse(
                 [

lib/Controller/MetricsController.php

@@ -78,7 +78,7 @@ public function __construct(
     public function index(): DataDisplayResponse
     {
         try {
-            $prefix = self::METRIC_PREFIX;
+            $prefix  = self::METRIC_PREFIX;
             $healthy = (int) $this->settingsService->isOpenRegisterAvailable();
 
             $lines = [

lib/Service/ItemService.php

@@ -146,7 +146,7 @@ public function delete(string $id, string $userId): string
      * OpenRegister owner of the object (via `@self.owner`).
      *
      * @param object|array<string,mixed> $object The object as returned by OpenRegister
-     *                                          (may be an entity or an associative array)
+     *                                           (may be an entity or an associative array)
      * @param string                     $userId The acting user's UID
      *
      * @return bool True if authorized, false otherwise.
@@ -159,7 +159,7 @@ private function isAuthorized(object|array $object, string $userId): bool
             return true;
         }
 
-        $owner = $this->extractOwner($object);
+        $owner = $this->extractOwner(object: $object);
         return ($owner !== null && $owner === $userId);
     }//end isAuthorized()
 
@@ -178,12 +178,20 @@ private function extractOwner(object|array $object): ?string
     {
         if (is_array($object) === true) {
             $self = ($object['@self'] ?? []);
-            return is_array($self) === true ? (($self['owner'] ?? null)) : null;
+            if (is_array($self) === true) {
+                return ($self['owner'] ?? null);
+            }
+
+            return null;
         }
 
         if (method_exists($object, 'getOwner') === true) {
             $owner = $object->getOwner();
-            return is_string($owner) === true ? $owner : null;
+            if (is_string($owner) === true) {
+                return $owner;
+            }
+
+            return null;
         }
 
         if (method_exists($object, 'jsonSerialize') === true) {