This repository was archived by the owner on May 29, 2026. It is now read-only.
Commit 46cd7d1
committed
refactor: OrganisationController::activate — restore if/else expressiveness
The previous diff replaced the original `if (PROVISIONING) { … } else
{ … }` with two independent `if` statements branching on the same
$status read. Behaviour is equivalent today (the two conditions are
mutually exclusive), but a future refactor that mutates `$status`
between the branches would silently double-run, and a reader can't
tell at a glance that exactly one branch fires.
Fold the second `if` back into the `else`.
Refs: #1419 review (minor) — discussion_r31874945271 parent 7196784 commit 46cd7d1
1 file changed
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1169 | 1169 | | |
1170 | 1170 | | |
1171 | 1171 | | |
1172 | | - | |
1173 | | - | |
1174 | | - | |
| 1172 | + | |
1175 | 1173 | | |
1176 | 1174 | | |
1177 | 1175 | | |
| |||
0 commit comments