Skip to content

Commit d2c50e2

Browse files
Merge pull request #3385 from Conflux-Chain/revert-3368-feat/getBlockByNumberPending1
Revert "espace rpc method eth_blockByNumber support pending tag"
2 parents 8179e8c + f64340e commit d2c50e2

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

changelogs/JSONRPC.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
## v3.0.3
88

99
1. Core Space `log` object add `blockTimestamp` field for method `cfx_getLogs` and `cfx_getFilterLogs`.
10-
2. eSpace `eth_getBlockByNumber` now support `pending` tag to get the pending block, which is actually the Conflux latest mined block.
1110

1211
## v3.0.2
1312

crates/rpc/rpc-eth-types/src/block_number.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ impl TryFrom<BlockId> for EpochNumber {
225225
BlockId::Num(num) => Ok(EpochNumber::Number(num)),
226226
BlockId::Latest => Ok(EpochNumber::LatestState),
227227
BlockId::Earliest => Ok(EpochNumber::Earliest),
228-
BlockId::Pending => Ok(EpochNumber::LatestMined),
228+
BlockId::Pending => Ok(EpochNumber::LatestState), /* TODO: LatestMined maybe is better or add a new Pending variant for EpochNumber */
229229
BlockId::Safe => Ok(EpochNumber::LatestConfirmed),
230230
BlockId::Finalized => Ok(EpochNumber::LatestFinalized),
231231
BlockId::Hash { .. } => Err(Error::InvalidParams(
@@ -249,7 +249,7 @@ impl From<BlockId> for BlockHashOrEpochNumber {
249249
BlockHashOrEpochNumber::EpochNumber(EpochNumber::Earliest)
250250
}
251251
BlockId::Pending => {
252-
BlockHashOrEpochNumber::EpochNumber(EpochNumber::LatestMined)
252+
BlockHashOrEpochNumber::EpochNumber(EpochNumber::LatestState)
253253
}
254254
BlockId::Safe => BlockHashOrEpochNumber::EpochNumber(
255255
EpochNumber::LatestConfirmed,

docs/rpc/readme.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)