From db464f8403ffda716f479e4d6b4aa6204ec3a6b2 Mon Sep 17 00:00:00 2001 From: Seongho Bae Date: Wed, 1 Jul 2026 15:00:54 +0900 Subject: [PATCH 1/2] Tighten OpenCode mapped-output regression review --- ci-review-prompt.md | 8 ++++++++ code-reviewer-prompt.md | 6 ++++++ 2 files changed, 14 insertions(+) diff --git a/ci-review-prompt.md b/ci-review-prompt.md index 38e769b04..5363f66dc 100644 --- a/ci-review-prompt.md +++ b/ci-review-prompt.md @@ -114,6 +114,14 @@ deployment, and operation paths instead of judging the changed hunk in isolation; flag contradictions between PR intent, code, docs, tests, schemas, generated files, UI rendering, and consumers. +When a PR replaces placeholder, inferred, or best-effort generated output with +concrete mapped values, review every producer and fallback path for the mapping. +Block approval if legacy inputs, manual UI-created objects, handle-based +objects, composite or ordered mappings, mismatched list lengths, or unmappable +records would be silently dropped or regress from the previous output. Require +tests for the concrete happy path and at least one fallback/legacy or composite +case when those paths exist. + Review object naming and reserved-word safety for changed database tables, columns, primary keys, foreign keys, indexes, constraints, API fields, events, configuration keys, routes, classes, functions, methods, generated models, and diff --git a/code-reviewer-prompt.md b/code-reviewer-prompt.md index 94bcb2961..41cc36763 100644 --- a/code-reviewer-prompt.md +++ b/code-reviewer-prompt.md @@ -128,6 +128,12 @@ between PR intent, code, docs, tests, schemas, generated files, UI rendering, and consumers. For changed scrolling, animation, transition, or motion behavior, verify that `prefers-reduced-motion: reduce` users are not forced through smooth scrolling or animated motion. +When a PR replaces placeholder, inferred, or best-effort generated output with +concrete mapped values, trace each producer and fallback path for that mapping. +Flag silent drops or regressions for legacy inputs, manual UI-created objects, +handle-based objects, composite or ordered mappings, mismatched list lengths, or +unmappable records, and expect tests for the concrete path plus at least one +fallback/legacy or composite path when present. For modal, dialog, drawer, popover, and toast overlays, verify viewport anchoring, inset coverage, scroll behavior, and mobile clipping; overlays must not be positioned relative to an inner app panel when the user needs a From d271f448f09a752e620fa954ef9ed85cda0e8841 Mon Sep 17 00:00:00 2001 From: Seongho Bae Date: Wed, 1 Jul 2026 15:28:16 +0900 Subject: [PATCH 2/2] Clarify mapped-output review rubric --- ci-review-prompt.md | 14 +++++++------- code-reviewer-prompt.md | 12 ++++++------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/ci-review-prompt.md b/ci-review-prompt.md index 5363f66dc..b3befafa8 100644 --- a/ci-review-prompt.md +++ b/ci-review-prompt.md @@ -114,13 +114,13 @@ deployment, and operation paths instead of judging the changed hunk in isolation; flag contradictions between PR intent, code, docs, tests, schemas, generated files, UI rendering, and consumers. -When a PR replaces placeholder, inferred, or best-effort generated output with -concrete mapped values, review every producer and fallback path for the mapping. -Block approval if legacy inputs, manual UI-created objects, handle-based -objects, composite or ordered mappings, mismatched list lengths, or unmappable -records would be silently dropped or regress from the previous output. Require -tests for the concrete happy path and at least one fallback/legacy or composite -case when those paths exist. +When a PR replaces placeholder output, inferred output, or best-effort-generated +output with concrete mapped values, trace every producer and fallback path for +the mapping. Block approval if legacy inputs, manual UI-created objects, +handle-based objects, composite or ordered mappings, mismatched list lengths, or +unmappable records would be silently dropped or regress compared to the previous +output. Require tests for the concrete happy path and at least one +fallback/legacy or composite case when those paths exist. Review object naming and reserved-word safety for changed database tables, columns, primary keys, foreign keys, indexes, constraints, API fields, events, diff --git a/code-reviewer-prompt.md b/code-reviewer-prompt.md index 41cc36763..25dc48143 100644 --- a/code-reviewer-prompt.md +++ b/code-reviewer-prompt.md @@ -128,12 +128,12 @@ between PR intent, code, docs, tests, schemas, generated files, UI rendering, and consumers. For changed scrolling, animation, transition, or motion behavior, verify that `prefers-reduced-motion: reduce` users are not forced through smooth scrolling or animated motion. -When a PR replaces placeholder, inferred, or best-effort generated output with -concrete mapped values, trace each producer and fallback path for that mapping. -Flag silent drops or regressions for legacy inputs, manual UI-created objects, -handle-based objects, composite or ordered mappings, mismatched list lengths, or -unmappable records, and expect tests for the concrete path plus at least one -fallback/legacy or composite path when present. +When a PR replaces placeholder output, inferred output, or best-effort-generated +output with concrete mapped values, trace each producer and fallback path for +that mapping. Flag silent drops or regressions for legacy inputs, manual +UI-created objects, handle-based objects, composite or ordered mappings, +mismatched list lengths, or unmappable records, and require tests for the +concrete path plus at least one fallback/legacy or composite path when present. For modal, dialog, drawer, popover, and toast overlays, verify viewport anchoring, inset coverage, scroll behavior, and mobile clipping; overlays must not be positioned relative to an inner app panel when the user needs a