From 4462c3c39f1e2a4f9576bf6baff51a47f5944808 Mon Sep 17 00:00:00 2001 From: Curtis Stallings Date: Sat, 31 Dec 2022 08:15:48 -0600 Subject: [PATCH 1/3] remove self.Dependencies models with many measures --- pytabular/measure.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/pytabular/measure.py b/pytabular/measure.py index 4f68893..6975083 100644 --- a/pytabular/measure.py +++ b/pytabular/measure.py @@ -17,7 +17,6 @@ def __init__(self, object, table) -> None: super().__init__(object) self.Table = table - self.Dependancies = self.get_dependancies(object) self._display.add_row("Expression", self._object.Expression, end_section=True) self._display.add_row("DisplayFolder", self._object.DisplayFolder) self._display.add_row("IsHidden", str(self._object.IsHidden)) @@ -28,17 +27,6 @@ def get_dependencies(self) -> pd.DataFrame: dmv_query = f"select * from $SYSTEM.DISCOVER_CALC_DEPENDENCY where [OBJECT] = '{self.Name}' and [TABLE] = '{self.Table.Name}'" return self.Table.Model.Query(dmv_query) - def get_dependancies(self, object) -> pd.DataFrame: - """Returns the dependant objects of a measure in a dataframe based on the information in $SYSTEM.DISCOVER_CALC_DEPENDENCY""" - return self.Table.Model.Adomd.Query( - f""" - select * - from $SYSTEM.DISCOVER_CALC_DEPENDENCY - where [OBJECT] = '{object.Name}' - and [TABLE] = '{object.Table.Name}' - """ - ) - class PyMeasures(PyObjects): def __init__(self, objects) -> None: From db9ee55dd961d75e2995b16fc403c8c5fe1cb77b Mon Sep 17 00:00:00 2001 From: Curtis Stallings Date: Sat, 31 Dec 2022 08:24:53 -0600 Subject: [PATCH 2/3] added two test for new methods --- test/test_3custom.py | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/test/test_3custom.py b/test/test_3custom.py index 265ebda..474c11f 100644 --- a/test/test_3custom.py +++ b/test/test_3custom.py @@ -2,7 +2,7 @@ These were designed selfishly for my own uses. So seperating out, to one day sunset and remove. """ -from test.config import testing_parameters, testingtablename +from test.config import testing_parameters, testingtablename, LOCAL_FILE import pytest @@ -44,3 +44,21 @@ def test_revert_table(model): ) == 1 ) + + +@pytest.mark.parametrize("model", testing_parameters) +def test_get_dependencies(model): + if len(model.Measures) > 0: + dependencies = model.Measures[0].get_dependencies() + assert len(dependencies) > 0 + else: + assert True + + +@pytest.mark.parametrize("model", testing_parameters) +def test_get_sample_values(model): + if LOCAL_FILE[0] == "AdventureWorks Sales": + df = model.Columns["Country"].get_sample_values() + assert len(df) > 0 + else: + assert True From 7c7a9183ab12b821665105940d5061aac73e1b4c Mon Sep 17 00:00:00 2001 From: Curtis Stallings Date: Sat, 31 Dec 2022 08:31:57 -0600 Subject: [PATCH 3/3] 0.2.8 --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 393bdd3..5a2637b 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta" [project] name = "python_tabular" -version = "0.2.7" +version = "0.2.8" authors = [ { name="Curtis Stallings", email="curtisrstallings@gmail.com" }, ]