CID-1192822: ids is a List<Long>, the cast to List<?> is removed

yadvr · yadvr · commit 92858afd55a2 · 2014-09-25T16:59:47.000+02:00
Signed-off-by: Rohit Yadav &lt;rohit.yadav@shapeblue.com&gt;
diff --git a/server/src/com/cloud/api/query/QueryManagerImpl.java b/server/src/com/cloud/api/query/QueryManagerImpl.java
@@ -912,11 +912,8 @@ private Pair<List<UserVmJoinVO>, Integer> searchForUserVMsInternal(ListVMsCmd cm
             sc.setParameters("display", display);
         }
 
-        if (ids != null) {
-            List<?> idList = (ids instanceof List<?> ? (List<?>)ids : null);
-            if (idList != null && !idList.isEmpty()) {
-                sc.setParameters("idIN", idList.toArray());
-            }
+        if (ids != null && !ids.isEmpty()) {
+            sc.setParameters("idIN", ids.toArray());
         }
 
         if (templateId != null) {

Original file line number	Diff line number	Diff line change
`@@ -912,11 +912,8 @@ private Pair<List<UserVmJoinVO>, Integer> searchForUserVMsInternal(ListVMsCmd cm`
`912`	`912`	`sc.setParameters("display", display);`
`913`	`913`	`}`
`914`	`914`
`915`		`- if (ids != null) {`
`916`		`- List<?> idList = (ids instanceof List<?> ? (List<?>)ids : null);`
`917`		`- if (idList != null && !idList.isEmpty()) {`
`918`		`- sc.setParameters("idIN", idList.toArray());`
`919`		`- }`
	`915`	`+ if (ids != null && !ids.isEmpty()) {`
	`916`	`+ sc.setParameters("idIN", ids.toArray());`
`920`	`917`	`}`
`921`	`918`
`922`	`919`	`if (templateId != null) {`