don't send None to statsd daemon as metric value

Author: dcrosta

datadog/dogstatsd/base.py

@@ -129,6 +129,9 @@ def decrement(self, metric, value=1, tags=None, sample_rate=1):
         >>> statsd.decrement('files.remaining')
         >>> statsd.decrement('active.connections', 2)
         """
+        if value is None:
+            return
+
         self._report(metric, 'c', -value, tags, sample_rate)
 
     def histogram(self, metric, value, tags=None, sample_rate=1):
@@ -222,6 +225,9 @@ def set(self, metric, value, tags=None, sample_rate=1):
         self._report(metric, 's', value, tags, sample_rate)
 
     def _report(self, metric, metric_type, value, tags, sample_rate):
+        if value is None:
+            return
+
         if sample_rate != 1 and random() > sample_rate:
             return
 

tests/unit/dogstatsd/test_statsd.py

@@ -421,6 +421,27 @@ def test_tags_from_environment_and_constant(self):
         statsd.gauge('gt', 123.4)
         t.assert_equal('gt:123.4|g|#country:canada,red,country:china,age:45,blue', statsd.socket.recv())
 
+    def test_gauge_doesnt_send_None(self):
+        self.statsd.gauge('metric', None)
+        assert self.recv() is None
+
+    def test_increment_doesnt_send_None(self):
+        self.statsd.increment('metric', None)
+        assert self.recv() is None
+
+    def test_decrement_doesnt_send_None(self):
+        self.statsd.decrement('metric', None)
+        assert self.recv() is None
+
+    def test_timing_doesnt_send_None(self):
+        self.statsd.timing('metric', None)
+        assert self.recv() is None
+
+    def test_histogram_doesnt_send_None(self):
+        self.statsd.histogram('metric', None)
+        assert self.recv() is None
+
+
 if __name__ == '__main__':
     statsd = statsd
     while True: