add support for coroutine functions#146
Closed
thehesiod wants to merge 4 commits intoDataDog:masterfrom
Closed
Conversation
Contributor
Author
|
I tried making the travis-ci tests to pass however the py2.x tests are looking at the await even when it isn't supposed to be included in that version. |
|
Sorry for the late answer @thehesiod! Your changes look great. I am going to take a pass on it this week, and plan for a release next week. Thanks! |
Contributor
Author
|
any updates? |
|
Thanks for your patience @thehesiod. 🙇 Your changes look good to me. I rebased your PR on top of the latest changes, and made some small adjustments in the organization of the different methods 🔀 . I opened a new PR with more details: #159. Let's close this PR in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change only the time it takes to create the coroutine is reported.