Fix ServiceCheck none parameters for calls from dogshell, etc on python3.#241
Merged
yannmh merged 2 commits intoDataDog:masterfrom Dec 1, 2017
Merged
Conversation
added 2 commits
November 10, 2017 11:31
|
Thanks @timvisher 🙇 . Cleaning out the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#206 (comment) introduced a basic python3 error where we attempted to iterate over a dictionary we were modifying, yielding an exception.
We didn't have any unit tests around this so I added one. This fixes both the actual call that I was making and provides a regression test.
I'm happy to clean up the commits once I get basic validation that this is the right direction.
If it's more important than I realize to actually filter out the
Noneparams, we'll need to change the way that we do that (iterating overkeysand building up a new dictionary with the appropriate key/value pairs.