Skip to content

Fix ServiceCheck none parameters for calls from dogshell, etc on python3.#241

Merged
yannmh merged 2 commits intoDataDog:masterfrom
timvisher:fix/service_check-none-parameters
Dec 1, 2017
Merged

Fix ServiceCheck none parameters for calls from dogshell, etc on python3.#241
yannmh merged 2 commits intoDataDog:masterfrom
timvisher:fix/service_check-none-parameters

Conversation

@timvisher
Copy link
Copy Markdown
Contributor

#206 (comment) introduced a basic python3 error where we attempted to iterate over a dictionary we were modifying, yielding an exception.

We didn't have any unit tests around this so I added one. This fixes both the actual call that I was making and provides a regression test.

I'm happy to clean up the commits once I get basic validation that this is the right direction.

If it's more important than I realize to actually filter out the None params, we'll need to change the way that we do that (iterating over keys and building up a new dictionary with the appropriate key/value pairs.

Tim Visher added 2 commits November 10, 2017 11:31
@yannmh
Copy link
Copy Markdown

yannmh commented Dec 1, 2017

Thanks @timvisher 🙇 .

Cleaning out the None parameters is not necessary anymore.

@yannmh yannmh merged commit 2a5dae4 into DataDog:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants