Do not override API parameters with default when calling initialize if they are already set#386
Merged
Do not override API parameters with default when calling initialize if they are already set#386
Conversation
zippolyte
force-pushed
the
hippo/initialize
branch
from
59b6c08 to
34e1edc
Compare
…f they are already set
zippolyte
force-pushed
the
hippo/initialize
branch
from
34e1edc to
f7e71c7
Compare
nmuesch
reviewed
Jun 4, 2019
| del os.environ["DATADOG_APP_KEY"] | ||
| del os.environ["DATADOG_HOST"] | ||
|
|
||
| def test_function_param_value(self): |
Contributor
There was a problem hiding this comment.
Should we add a quick test that tests the order these are used? Like provided attribute >> existing attribute >> environment variable?
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
…f they are already set (DataDog#386)
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
…f they are already set (DataDog#386)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #369