Add init option to add raw response to return values

[nmuesch]

Reverts #412 and re implements in a different way.

This PR makes the approach threadsafe while keeping backwards compatibility by using a configuration option passed through the global init. return_raw_response is set to false by default, but when its explicitly enabled, we return the decoded response as well as the raw response object from the submit method.

[gzussa]

LGTM

[mzizzi]

This is an improvement but it should be noted that the underlying response isn't always returned. The SDK's underlying HTTPClient could still cause exceptions to be thrown in some cases without returning the underlying response. e.g. some 4xx responses like 401 and all 5xx requests.

[mzizzi]

Explicitly notifying @nmuesch again.

[nmuesch]

Hey @mzizzi Thats a valid point! I was taking a look but I don't see a way to keep this backwards compatible, thread safe, and return the raw response always. The HTTP Request wrapper, as it currently stands, wouldn't be able to return the response object and maintain the error codes its returning.

I'm going to reopen #408 but I don't think this is something we'll be able to tackle in the short term.

[VidhushiniSrinivasan16]

@nmuesch currently I get this issue :
ImportError: cannot import name '_return_raw_response' from 'datadog.api' (/var/task/datadog/api/init.py)
How do we enable return_raw_response?

[zippolyte]

Hey @VidhushiniSrinivasan16 ! Looks like your issue is similar to #460
You need to call initialize with the return_raw_response argument to enable it.

I recently merged a PR (#461) that would add its default value to the module in order to solve that import error, but it is not yet released.

Hope this helps !

[VidhushiniSrinivasan16]

@zippolyte Thanks Henry. That worked for me!