Conversation
dabcoder
approved these changes
Oct 11, 2019
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gzussa
reviewed
Oct 15, 2019
Contributor
gzussa
left a comment
gzussa
left a comment
There was a problem hiding this comment.
Thanks for adding a test. 💯 However in this case, I wonder if it actually makes sense.
| """ | ||
| Test all the default setting are properly set before calling initialize | ||
| """ | ||
| from datadog.api import ( |
Contributor
There was a problem hiding this comment.
I am not really convinced by the usefulness of this test. It won't prevent anyone to not add settings in the init later. What do you think?
gzussa
approved these changes
Oct 15, 2019
Contributor
gzussa
left a comment
gzussa
left a comment
There was a problem hiding this comment.
At least, it checks default value so 🚢
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #460