Service Level Objectives : add 2 additional API endpoints now available#464
Merged
Service Level Objectives : add 2 additional API endpoints now available#464
Conversation
also add SLO client to dogshell this was missed last time
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
requested changes
Oct 22, 2019
Contributor
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
Looks good, let's just try to add exhaustive unit tests for your date utility functions
add freezegun dependency to do time-unit tests without being flaky
zippolyte
requested changes
Oct 23, 2019
Contributor
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
freezgun is only needed for unit tests.
Looks like it's failing for pypy2 for some reason
Co-Authored-By: Hippolyte HENRY <zippolyte@users.noreply.github.com>
Co-Authored-By: Hippolyte HENRY <zippolyte@users.noreply.github.com>
Co-Authored-By: Hippolyte HENRY <zippolyte@users.noreply.github.com>
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
the integration test failures have nothing to do with this PR afaik :( |
zippolyte
approved these changes
Oct 24, 2019
Contributor
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
Yeah you're right tests failure are a known problem at this point. We're working on fixing this. Will merge in the meantime
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
/api/v1/slo/can_delete&&/api/v1/slo/<id>/historyendpoints to match documentationalso add SLO client to dogshell this was missed last time