[MA-665] Add support for the Monitor.validate endpoint.#487
Merged
[MA-665] Add support for the Monitor.validate endpoint.#487
Monitor.validate endpoint.#487Conversation
armcburney
commented
Nov 27, 2019
| """ | ||
| @classmethod | ||
| def _trigger_class_action(cls, method, name, id=None, params=None, **body): | ||
| def _trigger_class_action(cls, method, action_name, id=None, params=None, **body): |
Member
Author
There was a problem hiding this comment.
I renamed the name parameter to action_name because when you splat the **body with a name in the dict, it causes there to be a conflict because of two name parameters.
Contributor
There was a problem hiding this comment.
Test is failing for embed because of that name change
Member
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
athap
reviewed
Nov 27, 2019
zippolyte
reviewed
Nov 29, 2019
zippolyte
approved these changes
Dec 9, 2019
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@zippolyte, the integration test failure was due to an unrelated test, which has been flaky. Is it okay to merge this? |
zippolyte
force-pushed
the
armcburney/monitor_validate_endpoint
branch
from
0321067 to
8468eb9
Compare
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@DataDog/monitor-app
The
validateendpoint can be used to check if a monitor definition is valid.