[MA-669] Add support for /v1/downtime/cancel/by_scope.#488
[MA-669] Add support for /v1/downtime/cancel/by_scope.#488armcburney merged 5 commits intomasterfrom
/v1/downtime/cancel/by_scope.#488Conversation
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nmuesch
left a comment
nmuesch
left a comment
There was a problem hiding this comment.
Thanks for this! Left two minor comments
|
|
||
| # Create downtime with scope_one | ||
| end = start + 1000 | ||
| downtime_one = dog.Downtime.create(scope=scope_one, start=start, end=end) |
There was a problem hiding this comment.
Thinking about subsequent test runs here. Would creating a downtime that already exists and is disabled just flip the disabled flag back to False?
There was a problem hiding this comment.
Ahh no, it will create a separate downtime with a different downtime["id"].
There was a problem hiding this comment.
Sorry, to clarify: it creates a new one because the start and end will be different depending on the test execution - so you schedule it for a different time period.
There was a problem hiding this comment.
Ahh ok that sounds good to me.
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 participants
@DataDog/monitor-app
https://docs.datadoghq.com/api/?lang=python#cancel-monitor-downtimes-by-scope