[api] option to unmute ApiError exceptions#76
Merged
Conversation
Datadog API HTTP client raises ApiError (400, 403 or 404 status codes) and HTTPError (others) exceptions for bad requests. BUT, we are, by default, muting any exceptions before they escape from the library. This makes difficult to catch errors and interact with the API. These changes introduces a `mute` option settable from `initialize` method, to select the desired behavior. Fix #74
yannmh
force-pushed
the
yann/silence-exceptions
branch
from
c7dca26 to
f476bab
Compare
tests/unit/api/helper.py
Outdated
Member
There was a problem hiding this comment.
Nitpick, but could you rename MockReponse --> MockResponse :)
Member
|
LGTM, love the tests! Just a small nitpick on a name, apart from that |
Fix typo in API unit tests: replace `MockReponse` with `MockResponse`.
Author
|
Thanks @olivielpeau. Merging ⚓ |
yannmh
pushed a commit
that referenced
this pull request
Aug 20, 2015
[api] option to unmute ApiError exceptions
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datadog API HTTP client raises ApiError (400, 403 or 404 status codes)
and HTTPError (others) exceptions for bad requests.
BUT, we are, by default, muting any exceptions before they escape from
the library. This makes difficult to catch errors and interact with the
API.
These changes introduces a
muteoption settable frominitializemethod, to select the desired behavior.
Fix #74