Retry first before losing message when receiving ENOTCONN#104
Merged
gmmeyer merged 2 commits intoDataDog:masterfrom Feb 4, 2019
Merged
Retry first before losing message when receiving ENOTCONN#104gmmeyer merged 2 commits intoDataDog:masterfrom
gmmeyer merged 2 commits intoDataDog:masterfrom
Conversation
blaines
changed the title
Contributor
Author
|
@gmmeyer I improved on the last PR of mine you looked at. This one makes an attempt to retry the message before dropping it. |
Contributor
Author
|
Thanks will a new version be built and sent to rubygems? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made another contribution in the context of the ENOTCONN error coming from our applications when we restart the Datadog agent. This new version attempts to retry before dropping a message.