Skip to content

Add service checks#11

Merged
wang-arthur merged 3 commits intomasterfrom
add_service_checks
May 19, 2015
Merged

Add service checks#11
wang-arthur merged 3 commits intomasterfrom
add_service_checks

Conversation

@wang-arthur
Copy link
Copy Markdown
Contributor

  • Service checks are supported by the agent's dogstatsd server starting in version 5.2.
  • Also fixes a couple bugs in event formatting

Comment thread lib/statsd.rb
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.each doesn't modify the array in-place here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased, so rm_pipes is now in-place

@LeoCavaille
Copy link
Copy Markdown
Member

Otherwise LGTM!

@remh
Copy link
Copy Markdown

remh commented May 18, 2015

@wang-arthur looks like it can't be merged, can you have a look please ?

@wang-arthur
Copy link
Copy Markdown
Contributor Author

Ah! will take a look -- forgot about this one

Arthur Wang added 3 commits May 19, 2015 15:30
@wang-arthur wang-arthur force-pushed the add_service_checks branch from 9140063 to e1d23c3 Compare May 19, 2015 15:42
wang-arthur pushed a commit that referenced this pull request May 19, 2015
@wang-arthur wang-arthur merged commit e014af9 into master May 19, 2015
@wang-arthur wang-arthur deleted the add_service_checks branch May 19, 2015 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants