Default sample rate#110
Merged
albertvaka merged 2 commits intoDataDog:masterfrom Jun 14, 2019
claytono:default-sample-rate
Merged
Default sample rate#110albertvaka merged 2 commits intoDataDog:masterfrom claytono:default-sample-rate
albertvaka merged 2 commits intoDataDog:masterfrom
claytono:default-sample-rate
Conversation
added 2 commits
April 18, 2019 12:48
The test case for the sampling rate equalling the random value was not testing the right scenario, which hid the fact that it was actually failing.
Allow providing a sample rate when creating the statsd object. This is only used if the caller doesn't provide one when updating a metric.
Contributor
|
Thanks for your contribution @claytono 😃And sorry this took so long to review 😥 Looks good to me, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a flag to the constructor to allow setting a default sample rate, if the caller doesn't set one on each call. This also fixes a minor problem in the sampling test cases and a bug with the sampling edge case that it was hiding.