Adding telemetry to the dogstatsd client#128
Merged
Conversation
hush-hush
force-pushed
the
maxime/statsd-telemetry
branch
from
1f94106 to
134f292
Compare
kbogtob
reviewed
Jan 14, 2020
Contributor
kbogtob
left a comment
kbogtob
left a comment
There was a problem hiding this comment.
Left some comments. I'm not a huge fan of having multiple classes by file, it's not really rubyesque. Same problem for tests, but it's more a project issue.
hush-hush
force-pushed
the
maxime/statsd-telemetry
branch
from
134f292 to
cc48850
Compare
remeh
approved these changes
Jan 16, 2020
Contributor
remeh
left a comment
remeh
left a comment
There was a problem hiding this comment.
Not a Ruby expert neither but looks pretty great to me! I've just left some questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having client side telemetry is very helpful in troubleshooting packet drop between the client and the datadog-agent.