use faster time method#70
Merged
masci merged 2 commits intoDataDog:masterfrom Feb 3, 2018
Merged
Conversation
Contributor
|
A bit concerned about dropping support for ruby < 2.1, let me ask product management. Any chance we can make this backward compatible (sorry not quite a rubyist here)? |
Contributor
Author
|
updated, should work nicely now :) |
Contributor
Author
|
please also check out the other PRs I made 💘 |
Contributor
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... also makes the method more symmetric
pro: faster
con: not stubbed by timecop and not available on ruby <2.1
... let me know what you think, I can fix up the specs if you want the PR