fail fast on unknown options#93
Merged
gmmeyer merged 2 commits intoDataDog:masterfrom Jun 7, 2018
Merged
Conversation
Contributor
Author
Contributor
|
@grosser can you address the rubocop failures? |
Contributor
Author
|
fixed ... turned out rubocop was linting for 1.9 which did not have keyword args :) |
Contributor
Author
|
ready! |
Contributor
Author
|
@gmmeyer merge ? |
Merged
gmmeyer
approved these changes
Jun 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevents typos and makes the initializer easier to read + less hash lookups ... might do that for more methods later
needs ruby 2.0+ ... 1.9 was "end of life" February 23, 2015 ... and whoever still runs it will get an old version since it requires 2.0+