Skip to content

fail fast on unknown options#93

Merged
gmmeyer merged 2 commits intoDataDog:masterfrom
grosser:grosser/keyword
Jun 7, 2018
Merged

fail fast on unknown options#93
gmmeyer merged 2 commits intoDataDog:masterfrom
grosser:grosser/keyword

Conversation

@grosser
Copy link
Copy Markdown
Contributor

@grosser grosser commented Jun 1, 2018

prevents typos and makes the initializer easier to read + less hash lookups ... might do that for more methods later

needs ruby 2.0+ ... 1.9 was "end of life" February 23, 2015 ... and whoever still runs it will get an old version since it requires 2.0+

@grosser
Copy link
Copy Markdown
Contributor Author

grosser commented Jun 1, 2018

@gmmeyer

@gmmeyer
Copy link
Copy Markdown
Contributor

gmmeyer commented Jun 6, 2018

@grosser can you address the rubocop failures?

@grosser grosser force-pushed the grosser/keyword branch from 4fc70b5 to 4f4050a Compare June 6, 2018 17:47
@grosser
Copy link
Copy Markdown
Contributor Author

grosser commented Jun 6, 2018

fixed ... turned out rubocop was linting for 1.9 which did not have keyword args :)
... also changed rake to run rubocop so users see failures before making PRs

@grosser grosser force-pushed the grosser/keyword branch from 4f4050a to fe89f5d Compare June 6, 2018 19:51
@grosser grosser force-pushed the grosser/keyword branch from fe89f5d to dbda85b Compare June 6, 2018 19:54
@grosser
Copy link
Copy Markdown
Contributor Author

grosser commented Jun 6, 2018

ready!

@grosser
Copy link
Copy Markdown
Contributor Author

grosser commented Jun 7, 2018

@gmmeyer merge ?

@grosser grosser mentioned this pull request Jun 7, 2018
@gmmeyer gmmeyer merged commit 8459020 into DataDog:master Jun 7, 2018
@masci masci added this to the 4.0.0 milestone Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants