Skip to content

add .open for short-lived reporting that does not leave sockets around#96

Merged
gmmeyer merged 1 commit intoDataDog:masterfrom
grosser:grosser/open
Jul 12, 2018
Merged

add .open for short-lived reporting that does not leave sockets around#96
gmmeyer merged 1 commit intoDataDog:masterfrom
grosser:grosser/open

Conversation

@grosser
Copy link
Copy Markdown
Contributor

@grosser grosser commented Jun 28, 2018

@grosser
Copy link
Copy Markdown
Contributor Author

grosser commented Jul 4, 2018

@gmmeyer

Copy link
Copy Markdown
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good idea! thank you!

Comment thread lib/datadog/statsd.rb
# Close the underlying socket
def close
@socket.close
@socket && @socket.close
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@gmmeyer gmmeyer merged commit db222f7 into DataDog:master Jul 12, 2018
@grosser
Copy link
Copy Markdown
Contributor Author

grosser commented Jul 13, 2018

how about a v4.0.0 release ? :D

@gmmeyer
Copy link
Copy Markdown
Contributor

gmmeyer commented Jul 17, 2018

@grosser we're gonna release soon! We just need to find a little time to do it!

@masci masci added this to the 4.0.0 milestone Aug 20, 2018
pudiva pushed a commit to pudiva/dogstatsd-ruby that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants