fix: drop lockdown_default_seclist to eliminate security-list race#115
Closed
yuhuyoyo wants to merge 1 commit into
Closed
fix: drop lockdown_default_seclist to eliminate security-list race#115yuhuyoyo wants to merge 1 commit into
yuhuyoyo wants to merge 1 commit into
Conversation
) Two Terraform resources both called UpdateSecurityList on the same VCN default security list: 1. The upstream oracle-terraform-modules/vcn/oci lockdown resource (enabled by lockdown_default_seclist = true) — zeroes all rules, has ignore_changes on egress/ingress. 2. oci_core_default_security_list.dd_default — sets egress-all + ICMP ingress only. Both fired within ~150 ms on terraform apply. When lockdown won the race it wiped egress rules, blocking Functions from reaching OCIR and causing FunctionInvokeImageNotAvailable (502) on every invocation. Fix: set lockdown_default_seclist = false so the upstream module never creates the conflicting resource. dd_default becomes the sole owner of the default security list and already provides the intended locked-down rule set (no SSH ingress, egress-all for OCIR reachability). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set
lockdown_default_seclist = falseinmodule.vcnin bothdatadog-terraform-onboardinganddatadog-integrationregional-stacks modules.Why
Two Terraform resources were both managing the same VCN default security list, causing a race condition on
terraform apply:module.vcn[0].oci_core_default_security_list.lockdown— created by the upstreamoracle-terraform-modules/vcn/ocimodule whenlockdown_default_seclist = true. It zeroes out all egress/ingress rules and usesignore_changeson them.oci_core_default_security_list.dd_default— our resource that sets egress-all + minimal ICMP ingress (no SSH).Both fired
UpdateSecurityListPUTs within ~150 ms during apply (confirmed in OCI audit logs). When the upstream lockdown resource won the race, all egress rules were wiped. Functions could no longer reach OCIR to pull their images, and every Service Connector Hub invocation returned:With
lockdown_default_seclist = false, the upstream module never creates the conflicting resource.dd_defaultbecomes the sole owner of the default security list with the correct rules — preserving the security posture from PR #99 (no SSH ingress, egress-all for OCIR reachability).Fixes #109