From 1133966bcac71c59d5e2926e0b7e97bd02d2f2e7 Mon Sep 17 00:00:00 2001 From: Nicolas Vierge Date: Wed, 18 Dec 2024 09:07:08 +0100 Subject: [PATCH 1/2] fix(#26): avoid NullReferenceException when creating database --- src/dbup-postgresql/PostgresqlExtensions.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/dbup-postgresql/PostgresqlExtensions.cs b/src/dbup-postgresql/PostgresqlExtensions.cs index 8e8448c..3dda4b4 100644 --- a/src/dbup-postgresql/PostgresqlExtensions.cs +++ b/src/dbup-postgresql/PostgresqlExtensions.cs @@ -147,10 +147,10 @@ public static void PostgresqlDatabase(this SupportedDatabasesForEnsureDatabase s /// public static void PostgresqlDatabase(this SupportedDatabasesForEnsureDatabase supported, string connectionString, IUpgradeLog logger) { - PostgresqlDatabase(supported, connectionString, logger, (PostgresqlConnectionOptions)null); + PostgresqlDatabase(supported, connectionString, logger, new PostgresqlConnectionOptions()); } - - private static void PostgresqlDatabase(this SupportedDatabasesForEnsureDatabase supported, string connectionString, IUpgradeLog logger, X509Certificate2 certificate) + + public static void PostgresqlDatabase(this SupportedDatabasesForEnsureDatabase supported, string connectionString, IUpgradeLog logger, X509Certificate2 certificate) { var options = new PostgresqlConnectionOptions { @@ -159,7 +159,7 @@ private static void PostgresqlDatabase(this SupportedDatabasesForEnsureDatabase PostgresqlDatabase(supported, connectionString, logger, options); } - private static void PostgresqlDatabase( + public static void PostgresqlDatabase( this SupportedDatabasesForEnsureDatabase supported, string connectionString, IUpgradeLog logger, From d8b49a0ec147b5a956328ce693ea08980215d5d0 Mon Sep 17 00:00:00 2001 From: Robert Wagner Date: Wed, 18 Dec 2024 19:40:26 +1000 Subject: [PATCH 2/2] Updated approval file --- src/Tests/ApprovalFiles/NoPublicApiChanges.Run.approved.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Tests/ApprovalFiles/NoPublicApiChanges.Run.approved.cs b/src/Tests/ApprovalFiles/NoPublicApiChanges.Run.approved.cs index 12ef4f6..00d5ce0 100644 --- a/src/Tests/ApprovalFiles/NoPublicApiChanges.Run.approved.cs +++ b/src/Tests/ApprovalFiles/NoPublicApiChanges.Run.approved.cs @@ -16,6 +16,8 @@ public static void PostgresqlDatabase(this DbUp.SupportedDatabasesForEnsureDatab public static void PostgresqlDatabase(this DbUp.SupportedDatabasesForEnsureDatabase supported, string connectionString, System.Security.Cryptography.X509Certificates.X509Certificate2 certificate) { } public static void PostgresqlDatabase(this DbUp.SupportedDatabasesForEnsureDatabase supported, string connectionString, DbUp.Postgresql.PostgresqlConnectionOptions connectionOptions) { } public static void PostgresqlDatabase(this DbUp.SupportedDatabasesForEnsureDatabase supported, string connectionString, DbUp.Engine.Output.IUpgradeLog logger) { } + public static void PostgresqlDatabase(this DbUp.SupportedDatabasesForEnsureDatabase supported, string connectionString, DbUp.Engine.Output.IUpgradeLog logger, System.Security.Cryptography.X509Certificates.X509Certificate2 certificate) { } + public static void PostgresqlDatabase(this DbUp.SupportedDatabasesForEnsureDatabase supported, string connectionString, DbUp.Engine.Output.IUpgradeLog logger, DbUp.Postgresql.PostgresqlConnectionOptions connectionOptions) { } } namespace DbUp.Postgresql {