Support WSL

[Hotell]

Are you requesting a feature or reporting a bug?

bug

What is the current behavior?

when providing path from WSL, testcafe errors out,

$ npx testcafe path:/mnt/c/Program\ Files\ \(x86\)/Google/Chrome/Application/chrome.exe test.js

ERROR Was unable to open the browser "path:/mnt/c/Program Files (x86)/Google/Chrome/Application/chrome.exe" due to error.

maybe @bitcrazed can help us with some insights why may this happening from WSL perspective

What is the expected behavior?

make parth properly work from WSL

How would you reproduce the current behavior (if this is a bug)?

see attached gif

Specify your

• operating system: Win 10 CU with WSL - ubuntu 16
• testcafe version: testcafe@0.16.2
• node.js version: 8.1.4

[bitcrazed]

Have you tried wrapping the entire path in quotes (due to the spaces)?

$ npx testcafe path:'/mnt/c/Program Files (x86)/Google/Chrome/Application/chrome.exe test.js'

[Hotell]

thanks for stepping in @bitcrazed . That didn't help unfortunately, same error. I guess issue is with testcafe implementation

npx testcafe path:'/mnt/c/Program Files (x86)/Google/Chrome/Application/chrome.exe' test.js
ERROR Was unable to open the browser "path:/mnt/c/Program Files (x86)/Google/Chrome/Application/chrome.exe" due to error.

Error: The specified browser name is not valid!
    at BrowserProviderPluginHost._callee3$ (/mnt/c/Users/hoche/Documents/Devel/test/testcafe-example/node_modules/testcafe/lib/browser/provider/built-in/path.js:159:35
)
    at tryCatch (/mnt/c/Users/hoche/Documents/Devel/test/testcafe-example/node_modules/regenerator-runtime/runtime.js:65:40)
    at Generator.invoke [as _invoke] (/mnt/c/Users/hoche/Documents/Devel/test/testcafe-example/node_modules/regenerator-runtime/runtime.js:303:22)
    at Generator.prototype.(anonymous function) [as next] (/mnt/c/Users/hoche/Documents/Devel/test/testcafe-example/node_modules/regenerator-runtime/runtime.js:117:21)
    at step (/mnt/c/Users/hoche/Documents/Devel/test/testcafe-example/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /mnt/c/Users/hoche/Documents/Devel/test/testcafe-example/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
    at <anonymous>

[Hotell]

ha! so I've spent few minutes on debugging async/await compiled to es5 ( feels like shooting yourself in the head btw ehm .... ) and I found the issue and got it working :)

command:
npx testcafe path:"/mnt/c/Program Files (x86)/Google/Chrome/Application/chrome.exe" test.js --hostname localhost

So where is the issue?
-> _handleString

-> and most particular in this call of splitQuotedText

where splitChar param is set to ' ' which in will parse path to chrome badly -> like this

this ->
path:"/mnt/c/Program Files (x86)/Google/Chrome/Application/chrome.exe"

will be parsed to:

{ str: '/mnt/c/Program Files (x86)/Google/Chrome/Application/chrome.exe',
  args: [ 'Files', '(x86)/Google/Chrome/Application/chrome.exe' ],
  path: '/mnt/c/Program' }

which is of course wrong and whole script will error

So how to fix it?

Don't know why there is empty space as splitChar, but if we change it to for instance for comma , everything will start to work. I can submit PR if you want, this is indeed a deal breaker for my daily workflow as I'm using WSL 100% for work.

-var args = splitQuotedText(str, ' ', '`"\'');
+var args = splitQuotedText(str, ',', '`"\'');

[Hotell]

cc @kirovboris

[AlexanderMoskovkin]

Hi @Hotell,

You've found a right way to pass a browser argument, but our code works as we expect.
Let me explain why (meanwhile I suppose it should be described in the docs).
You can pass a path to a browser executable file with some browser argruments in the following way:
path:path/to/chrome.exe --incognito. The _handleString function split this args by ' ', so it's ok.
To make it workable you should wrap it with quotes:
testcafe "path:path/to/chrome.exe --incognito" test.js

Since the path can contain spaces too you should be able to wrap the path with some other quotes.
As you can see from this line TestCafe allows to use three types of quotes: ', ", `.

So, to make your example workable you can just wrap the path with quotes:
testcafe "path:'path with space/to/chrome.exe' --incognito" test.js

You can see this type of using in our tests.

[Hotell]

Thanks for explanation why is ' ' , although your quotes doesn't work for all your type of quotes , also your test is covering just one use case, when using backticks `

following does not work:

the only combination that works is backticks + single quotes as a wrapper:

So either way:

• it's a bug ( that it handles correctly only 3rd usecase ? )
• it's demanded behaviour ( that it works solely with backticks ) and a PR to the docs needs to happen

Pls lemme know thx!

[AlexanderMoskovkin]

@Hotell You are right. We should check it

[Hotell]

I found it in docs actually ( my mistake that I didn't read thoroughly before :( ) but provided example doesn't work as I've mentioned

https://devexpress.github.io/testcafe/documentation/using-testcafe/command-line-interface.html#starting-browser-with-arguments

You can also specify arguments for portable browsers. If a path to a browser contains spaces, the path should be surrounded with backticks:

testcafe "path:`C:\Program Files (x86)\Google\Chrome\Application\chrome.exe` --start-fullscreen" tests/sample-fixture.js

[AndreyBelym]

Hello @Hotell! The example from docs was written for cmd shell, but it seems like you are using bash. The case with double quotes didn't work for you because backticks have special semantics in bash, and should be escaped with \ or should be inside single quotes (bash does some interpretation for strings inside " but not for strings inside '). I think we should fix docs at least, add an example for *NIX-like shells.

Also I'll try to improve quotes handling to allow using regular quotes to separate spaces-containing path and arguments in the path provider. Because experience shows that backticks are counter-intuitive, and people regularly runs into issues with them.

[Hotell]

sounds good @AndreyBelym, cheers !

P.S.: yes I'm using windows subsystem linux for development, so bash