0.5.0: honour neon excludePaths (closes #1)#2
Merged
Conversation
Warm worker was force-analyzing files the CLI phpstan would skip,
producing false positives on test files whose lifecycle bootstrap
(setUpBeforeClass / tearDownAfterClass) wasn't loaded.
PhpstanRunner now:
- Caches excludePaths.{analyse,analyseAndScan} at boot via the
existing dump-parameters --json round-trip
- Short-circuits analyse() with [] when the file matches
- Check fires BEFORE ensureWorker() on warm calls — excluded
files pay no worker boot cost
- fnmatch handles absolute + relative globs + any-suffix match
on absolute paths (so `tests/unit/*` matches
/repo/tests/unit/Foo.php)
TDD: 5 unit tests written first (RED), then implemented (GREEN).
Closes #1.
Co-Authored-By: Max <noreply>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.5.0: honour neon excludePaths (closes #1)
Summary
PhpstanRunnernow cachesexcludePaths.{analyse,analyseAndScan}at boot via the existingdump-parameters --jsoncallanalyse()returns[]when the file matches an exclude glob — beforeensureWorker()on warm calls, so excluded files pay no worker boot costTest plan
phpunit tests/Unit/PhpstanRunnerExcludeTest.php— 5/5phpunit(full) — 12/12excludePathsreturnserrors: []instead of false-positiveproperty.unusedreports./supertool validate:Dvsi/dvsi-private/tests/unit/.../SomeTest.phpshould now skip cleanly