From 78bafbdbd14db16e84006809a845e4893cad93da Mon Sep 17 00:00:00 2001 From: lelenei Date: Thu, 30 Dec 2021 21:00:05 +0800 Subject: [PATCH 1/3] fix: nftscan content-type --- packages/web3-providers/src/NFTScan/index.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/web3-providers/src/NFTScan/index.ts b/packages/web3-providers/src/NFTScan/index.ts index 61bc6df20b38..03ae8a436739 100644 --- a/packages/web3-providers/src/NFTScan/index.ts +++ b/packages/web3-providers/src/NFTScan/index.ts @@ -29,7 +29,7 @@ async function getToken() { async function fetchAsset(path: string, body?: unknown) { const response = await fetch(urlcat(NFTSCAN_BASE_API, path), { method: 'POST', - headers: { 'Access-Token': await getToken() }, + headers: { 'Access-Token': await getToken(), 'Content-type': 'application/json' }, body: JSON.stringify(body), }) if (!response.ok) return @@ -65,7 +65,7 @@ export class NFTScanAPI implements NonFungibleTokenAPI.Provider { erc: 'erc721', user_address: address, }) - if (!response) return [] + if (!response || !response.data) return [] return response.data .map((x) => { const contractDetailed = createERC721ContractDetailed( @@ -96,12 +96,11 @@ export class NFTScanAPI implements NonFungibleTokenAPI.Provider { total: number }>('getAllNftByUserAddress', { page_size: size, - // page is start from 1 in NFTScan page_index: page + 1, use_address: from, erc: 'erc721', }) - if (!response) + if (!response || !response.data) return { data: [], hasNextPage: false, From 038959021c5dc76b1c4d1c42ef7e3a545c5c12bb Mon Sep 17 00:00:00 2001 From: lelenei Date: Fri, 31 Dec 2021 09:15:19 +0800 Subject: [PATCH 2/3] fix: contract icon from nftscan api --- packages/web3-providers/src/NFTScan/index.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/web3-providers/src/NFTScan/index.ts b/packages/web3-providers/src/NFTScan/index.ts index 03ae8a436739..7386a1b4373d 100644 --- a/packages/web3-providers/src/NFTScan/index.ts +++ b/packages/web3-providers/src/NFTScan/index.ts @@ -72,6 +72,9 @@ export class NFTScanAPI implements NonFungibleTokenAPI.Provider { ChainId.Mainnet, x.nft_contract_address, x.nft_platform_name, + undefined, + undefined, + x.nft_platform_image, ) const balance = x.nft_asset.length return { contractDetailed, balance } From 75cc940d46d21d455467fb34fc3b5d068ee83534 Mon Sep 17 00:00:00 2001 From: lelenei Date: Fri, 31 Dec 2021 10:52:43 +0800 Subject: [PATCH 3/3] fix: reply review --- packages/web3-providers/src/NFTScan/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/web3-providers/src/NFTScan/index.ts b/packages/web3-providers/src/NFTScan/index.ts index 7386a1b4373d..3bfb6fe3faf1 100644 --- a/packages/web3-providers/src/NFTScan/index.ts +++ b/packages/web3-providers/src/NFTScan/index.ts @@ -65,7 +65,7 @@ export class NFTScanAPI implements NonFungibleTokenAPI.Provider { erc: 'erc721', user_address: address, }) - if (!response || !response.data) return [] + if (!response?.data) return [] return response.data .map((x) => { const contractDetailed = createERC721ContractDetailed( @@ -103,7 +103,7 @@ export class NFTScanAPI implements NonFungibleTokenAPI.Provider { use_address: from, erc: 'erc721', }) - if (!response || !response.data) + if (!response?.data) return { data: [], hasNextPage: false,