From 15d2d84ccf10a43013a410f7938018220d6ea14f Mon Sep 17 00:00:00 2001 From: lelenei Date: Sat, 1 Jan 2022 11:27:08 +0800 Subject: [PATCH 1/2] fix: check address --- .../mask/src/plugins/Profile/SNSAdaptor/hooks/useDonations.ts | 1 + .../mask/src/plugins/Profile/SNSAdaptor/hooks/useFootprints.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useDonations.ts b/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useDonations.ts index 29f7f2f3ef7b..3b711969f4e4 100644 --- a/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useDonations.ts +++ b/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useDonations.ts @@ -3,6 +3,7 @@ import { PluginProfileRPC } from '../../messages' export function useDonations(address: string) { return useAsync(async () => { + if (!address) return const response = await PluginProfileRPC.getDonations(address) return response.status ? response.assets : [] }, [address]) diff --git a/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useFootprints.ts b/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useFootprints.ts index 7fdb8e206fca..18a768b8a4d7 100644 --- a/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useFootprints.ts +++ b/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useFootprints.ts @@ -3,6 +3,7 @@ import { PluginProfileRPC } from '../../messages' export function useFootprints(address: string) { return useAsync(async () => { + if (!address) return const response = await PluginProfileRPC.getFootprints(address) return response.status ? response.assets : [] }, [address]) From 1f6f72828d4397ae745ea4f49aa67bbb5be737b3 Mon Sep 17 00:00:00 2001 From: lelenei Date: Thu, 6 Jan 2022 14:32:17 +0800 Subject: [PATCH 2/2] fix: reply review --- .../mask/src/plugins/Profile/SNSAdaptor/hooks/useDonations.ts | 2 +- .../mask/src/plugins/Profile/SNSAdaptor/hooks/useFootprints.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useDonations.ts b/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useDonations.ts index 3b711969f4e4..0749dbee236d 100644 --- a/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useDonations.ts +++ b/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useDonations.ts @@ -3,7 +3,7 @@ import { PluginProfileRPC } from '../../messages' export function useDonations(address: string) { return useAsync(async () => { - if (!address) return + if (!address) return [] const response = await PluginProfileRPC.getDonations(address) return response.status ? response.assets : [] }, [address]) diff --git a/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useFootprints.ts b/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useFootprints.ts index 18a768b8a4d7..df40199e465c 100644 --- a/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useFootprints.ts +++ b/packages/mask/src/plugins/Profile/SNSAdaptor/hooks/useFootprints.ts @@ -3,7 +3,7 @@ import { PluginProfileRPC } from '../../messages' export function useFootprints(address: string) { return useAsync(async () => { - if (!address) return + if (!address) return [] const response = await PluginProfileRPC.getFootprints(address) return response.status ? response.assets : [] }, [address])