Reportback Gallery bug

[aaronschachter]

The reportback gallery has become self aware.

Files are being added into the gallery view which have not been flagged as promoted, which is why editors are unable to unpromote the files (because no flagging record exists): http://screencast.com/t/Um3VEuG5cbU

• Alter dosomething_reportback_get_gallery_item_ids to filter by specific Flag ID for "Promoted"
• Reflag reportbacks per https://gist.github.com/aaronschachter/41c32353c87229bc3322

[aaronschachter]

The issue is that dosomething_reportback_get_gallery_item_ids is not checking for the specific Flag ID = 1. So as editors are flagging reportbacks, the flagged reportback ID's are showing up in the Gallery.

For now I am manually removing the reportback flags (and keeping a list of them here 41c32353c87229bc3322 to add back in) and have removed editor permissions to use the flagged_reportback flag.

[aaronschachter]

This one is tough to replicate without production data, it happens when file fid's and the reportback rbid's overlap.

[aaronschachter]

Seems like this is good to go on production, i've flagged my own reportback, which seemed to cause the wrong files to show up in the gallery -- and all closed galleries look good now.

cc: @mikefantini