This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Campaign form - Alt BG field fix#1161
Merged
aaronschachter merged 4 commits intoDoSomethingArchive:devfrom Mar 12, 2014
aaronschachter:save_vars_fix
Merged
Campaign form - Alt BG field fix#1161aaronschachter merged 4 commits intoDoSomethingArchive:devfrom aaronschachter:save_vars_fix
aaronschachter merged 4 commits intoDoSomethingArchive:devfrom
aaronschachter:save_vars_fix
Conversation
Contributor
|
👍 |
aaronschachter
added a commit
that referenced
this pull request
Mar 12, 2014
Campaign form - Alt BG field fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1134
Error was occurring because we're using a
file_managedform element to store a File fid, and wasn't updating the corresponding records in thefile_usagetable. This PR fixes that, implementing thedosomething_campaign_save_alt_bg_fidfunction to track the usage of files we're setting for eachalt_bg_fidvariable.Also gets rid of the
dosomething_campaign_get_custom_varnamesfunction, because it was just not readable at all by looping through it on the save (and not worth it for just 2 variables)