This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Official Rules Fix#1255
Merged
DFurnes merged 4 commits intoDoSomethingArchive:devfrom Mar 14, 2014
mmwtsn:official-rules
Merged
Official Rules Fix#1255DFurnes merged 4 commits intoDoSomethingArchive:devfrom mmwtsn:official-rules
DFurnes merged 4 commits intoDoSomethingArchive:devfrom
mmwtsn:official-rules
Conversation
Contributor
|
🔌 🐘 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The campaign "official rules" link was printing regardless of whether or not a PDF has been updated because the
srcwas checked on the template which always has a base URL value set.Visually, it was the wrong color and not spaced correctly.
Fix
This change creates a
$official_rulesvariable to check against in place of the site's base URL, makes the link white and gives it some breathing room.Fixes #1147
Fixes #1205