This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Mailchimp grouping_id and group_name vars#1481
Merged
aaronschachter merged 4 commits intoDoSomethingArchive:devfrom Mar 24, 2014
aaronschachter:mailchimp_grouping
Merged
Mailchimp grouping_id and group_name vars#1481aaronschachter merged 4 commits intoDoSomethingArchive:devfrom aaronschachter:mailchimp_grouping
aaronschachter merged 4 commits intoDoSomethingArchive:devfrom
aaronschachter:mailchimp_grouping
Conversation
Contributor
There was a problem hiding this comment.
Should there be support for additional "grouping_id"s? or do we want to insist on there only being one? variable_get($mailchimp_grouping_id) suggests there will only be one grouping. I assume so, just flagging for consideration.
Contributor
Author
There was a problem hiding this comment.
There is support for additional grouping_id's. This function is being called foreach staff pick. The mailchimp_grouping_id variable is defined in line 35, it will be unique for each staff pick campaign.
Contributor
Author
|
@deezone do the changes look ok? |
Contributor
|
👍 |
aaronschachter
added a commit
that referenced
this pull request
Mar 24, 2014
Mailchimp grouping_id and group_name vars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles all code necessary for #1454. Will close out once we update the config form with the relevant
grouping_idandgroup_namevalues.Adds
grouping_idandgroup_namevariables into signup config so we can avoid hardcoding them in Message Broker.