Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Collect user address in signup data form#1533

Merged
aaronschachter merged 6 commits intoDoSomethingArchive:devfrom
aaronschachter:update_address
Mar 26, 2014
Merged

Collect user address in signup data form#1533
aaronschachter merged 6 commits intoDoSomethingArchive:devfrom
aaronschachter:update_address

Conversation

@aaronschachter
Copy link
Contributor

Closes #1484

  • Implements only what we need for Comeback Clothes, which is just enter/confirm user address in a modal.
  • Adds a patch for addressfield module to enable a sweet addressfield form element to do that.
  • Adds documentation, listing what hasn't been implemented yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't have to load the user again here...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do need to load the user here, because the address field is not available on just the global $user. The address field is used as the default value for the address element.

@angaither
Copy link
Contributor

oookkk :shipit:

@aaronschachter
Copy link
Contributor Author

@angaither Updated

aaronschachter added a commit that referenced this pull request Mar 26, 2014
Collect user address in signup data form
@aaronschachter aaronschachter merged commit 1805394 into DoSomethingArchive:dev Mar 26, 2014
@aaronschachter aaronschachter deleted the update_address branch March 26, 2014 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Signup Data Form

2 participants