Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Validate address#1768

Merged
angaither merged 6 commits intoDoSomethingArchive:devfrom
angaither:validate-address
Apr 14, 2014
Merged

Validate address#1768
angaither merged 6 commits intoDoSomethingArchive:devfrom
angaither:validate-address

Conversation

@angaither
Copy link
Contributor

  • Add system settings form
  • Valid XML according the UPS guidelines
  • Makes post request to UPS api & print the results.

- create menu callback for an ajax request
- format XML request

Refs #74
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not store this variable with the same prefix, dosomething_ups .. ? Or additionally use the dosomething_user module prefix as well to better specify where its being set?

@angaither
Copy link
Contributor Author

@aaronschachter at least I'm consistent. 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is all of this new code for the USPS or UPS? If USPS, please update the variable and permission names accordingly (or fix this comment to standardize)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fake xml stuff was originally for UPS, will be updated in a new PR.

Formats all XML as UPS defines.
Return the results from the api call to the page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question, all this code is for USPS, not UPS right? Can we do a global replace for anything UPS as USPS if so?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all for UPS, don't think there's anything referencing USPS anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet.

angaither added a commit that referenced this pull request Apr 14, 2014
@angaither angaither merged commit 5746040 into DoSomethingArchive:dev Apr 14, 2014
@angaither angaither deleted the validate-address branch April 14, 2014 21:53
@angaither angaither mentioned this pull request Apr 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants