Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

User profile design updates#1958

Merged
weerd merged 4 commits intoDoSomethingArchive:devfrom
weerd:user-profile--design-updates
May 5, 2014
Merged

User profile design updates#1958
weerd merged 4 commits intoDoSomethingArchive:devfrom
weerd:user-profile--design-updates

Conversation

@weerd
Copy link
Contributor

@weerd weerd commented May 2, 2014

Lots of updates to design.

Resolves #1929

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we could do with a normal CSS fallback in a mixin instead of Modernizr?

$gradient: rgba(#000, 0) 40%, rgba(#000, .2) 70%, rgba(#000, .5) 87%, rgba(#000, .85) 100%;
background: transparent image-url('black-gradient.png') 0 bottom repeat-x;
@include prefixer(linear-gradient, $gradient, webkit moz spec);

Just seems like a lot of selector action.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't you be doing an extra HTTP request on modern browsers for a PNG they don't need since they support gradients though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit of selector action, but only really ends up applying to IE8 ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't make the HTTP request if the rule is overridden, I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, not sure. Modernizr is for this kind of stuff though. Allowing you to target via browser capabilities/support. Plus, once we no longer need to support IE8, all you need to do is remove any declarations using .no-.

weerd added a commit that referenced this pull request May 5, 2014
@weerd weerd merged commit 1c62d5f into DoSomethingArchive:dev May 5, 2014
@weerd weerd deleted the user-profile--design-updates branch May 5, 2014 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[User Profile] Style cta for when no signups showing.

2 participants