This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Make footer links editable#2261
Merged
desmondmorris merged 4 commits intoDoSomethingArchive:devfrom Jun 2, 2014
Merged
Conversation
…d social toggles from theme settings
Contributor
There was a problem hiding this comment.
I'm not crazy about using the paths as the input here, it'd be nicer to use node/[nid]. Even though you are using the l function in the preprocess, i believe this would break things if the path changes.
Contributor
|
Also, fixes #1321 |
Contributor
|
Looks good to me 👍 |
Contributor
Contributor
|
Looks good once I manually added the line breaks in the theme settings. |
…cters for actual line breaks
Contributor
Author
|
@aaronschachter @DFurnes that should do the trick. |
Contributor
|
Looks good! 👍 |
desmondmorris
added a commit
that referenced
this pull request
Jun 2, 2014
Make footer links editable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What's this PR do?
We will need to revisit and re-org this theme-settings form as it is quickly growing. A proper gameplan/rules may be worth thinking about @DFurnes
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
This is the starting point to making the footer completely manageable via theme settings.
What are the relevant tickets?
Fixes #2092
Screenshots (if appropriate)
Super primitive link adding capabilities: Should be good enough for now

cc: @weerd @DFurnes @aaronschachter - its not particularly artisanal, but its a start. chime in please