Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Update campaign confirmation message per SPG's request.#2286

Merged
DFurnes merged 2 commits intoDoSomethingArchive:devfrom
DFurnes:all-that-bullshit
May 22, 2014
Merged

Update campaign confirmation message per SPG's request.#2286
DFurnes merged 2 commits intoDoSomethingArchive:devfrom
DFurnes:all-that-bullshit

Conversation

@DFurnes
Copy link
Contributor

@DFurnes DFurnes commented May 22, 2014

💯 🐎 🏁 💥

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t() dat

@angaither
Copy link
Contributor

👍

DFurnes added a commit that referenced this pull request May 22, 2014
Update campaign confirmation message per SPG's request.
@DFurnes DFurnes merged commit c73634b into DoSomethingArchive:dev May 22, 2014
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may cause errors if type is not set. We should be checking for said errors on pages like the user login or password.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some quick clicking around on my local and not seeing any errors on campaigns, static content, user, or home pages.

@barryclark Something to watch out for while testing just in case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there, just behind the scenes. Check out admin/reports/dblog

Notice: Trying to get property of non-object in paraneue_dosomething_preprocess_page() (line 35 of /var/www/beta.dosomething.org/releases/20140522191445/lib/themes/dosomething/paraneue_dosomething/includes/preprocess.inc).

Can replicate by visiting user/password as an anon user from incognito.

@DFurnes DFurnes deleted the all-that-bullshit branch May 22, 2014 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants