This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Image upload fix#2436
Merged
DFurnes merged 6 commits intoDoSomethingArchive:devfrom Jun 5, 2014
DFurnes:image-upload-fix
Merged
Image upload fix#2436DFurnes merged 6 commits intoDoSomethingArchive:devfrom DFurnes:image-upload-fix
DFurnes merged 6 commits intoDoSomethingArchive:devfrom
DFurnes:image-upload-fix
Conversation
Contributor
Author
|
Tested uploading a picture in the reportback modal and then checking that it submits successfully and shows the correct photo when returning to the modal to edit submission. Tested in the following browsers: Windows 7: IE9, IE10, IE11, Chrome 26, Chrome 35, Firefox 10, There's a visual bug where the upload form isn't aligned correctly in Firefox 29. Gonna work on that, put up a patch, and re-test. 😥 |
Contributor
Author
|
The fix was just a CSS change, so shouldn't be too dangerous. Re-tested on iOS 6, IE 9, IE 10, Safari 7, and Firefox 29. Should be good to merge. 🐎 |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2423.