This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Salt: improve drush provisioning. Fixes #2616.#2796
Merged
sergiitk merged 1 commit intoDoSomethingArchive:devfrom Jul 8, 2014
sergiitk:drush-provisioning-improvements
Merged
Salt: improve drush provisioning. Fixes #2616.#2796sergiitk merged 1 commit intoDoSomethingArchive:devfrom sergiitk:drush-provisioning-improvements
sergiitk merged 1 commit intoDoSomethingArchive:devfrom
sergiitk:drush-provisioning-improvements
Conversation
Improve drush provisioning ------ 1. Move drush salt state rules to dedicated `drush.sls` 2. Move drush installation from `lamp-drupal.sls` to `drush.sls` 3. Simplify drush installation: - Use git state plugin instead of complex command chain - Create drush symbolic link in the same `drush` task using `cmd.wait` - Run all commands as `vagrant` user 4. Simplify terminus drush module installation - Use git state plugin instead of complex command chain - Checkout all files as `vagrant` user so `chown` not needed anymore - Run all commands as `vagrant` user 5. Set state dependencies 6. Clear drush cache at the end of drush salt state script Fix and improve drush user settings ------ 1. Ensure that `/home/vagrant/.drush/` exists. Fixes #2616 2. Move ds drush aliases and policy provisioning to `drush.sls`. Since make_local and terminus plugins are installed to `/home/vagrant` anyway, it didn't make sense to keep aliases and policy in `dosomething.sls`. It just impaired code readability. 3. Move `ds.aliases.drushrc.php` and `policy.drush.inc` to `drush` folder 4. Provision all files from `drush` to `/home/vagrant/.drush/` recursively Testing ------ - You can fix #2616 issue simply by running `vagrant provision` - New build: `drush`, `terminus` and `make_local` plugins should work as usual, `bin/ds pull stage` should not throw "no aliases" error
Contributor
|
👍 |
sergiitk
pushed a commit
that referenced
this pull request
Jul 8, 2014
…rovements Salt: improve drush provisioning. Fixes #2616.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve drush provisioning
drush.slslamp-drupal.slstodrush.slsdrushtask usingcmd.waitvagrantuservagrantuser sochownnot needed anymorevagrantuserFix and improve drush user settings
/home/vagrant/.drush/exists. Fixes Salt: drush config files are not moved into place #2616drush.sls.Since make_local and terminus plugins are installed
to
/home/vagrantanyway, it didn't make sense to keep aliases and policyin
dosomething.sls. It just impaired code readability.ds.aliases.drushrc.phpandpolicy.drush.inctodrushfolderdrushto/home/vagrant/.drush/recursivelyTesting
vagrant provisiondrush,terminusandmake_localplugins should work as usual,bin/ds pull stageshould not throw "no aliases" error