Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

I18N: Make "What is DoSomething.org?" editable.#2805

Merged
sergiitk merged 2 commits intoDoSomethingArchive:devfrom
sergiitk:editable-about-block
Jul 10, 2014
Merged

I18N: Make "What is DoSomething.org?" editable.#2805
sergiitk merged 2 commits intoDoSomethingArchive:devfrom
sergiitk:editable-about-block

Conversation

@sergiitk
Copy link
Contributor

DOS-12:
Change the "What is DoSomething.org?" header item to "Who Are We?" for
all affiliate sites.

[DOS-12](https://jira.dosomething.org/browse/DOS-12):
Change the "What is DoSomething.org?" header item to "Who Are We?" for
all affiliate sites.
@sergiitk
Copy link
Contributor Author

DOS-12 is ready, "What is DoSomething.org?" is changeable now. However, it may also be needed to change a link to actual "About us" page. @barryclark, @julielorch could you clarify that?
@angaither could you please review this PR?

@barryclark
Copy link
Contributor

@sergii-tkachenko I don't think the link to the About Us page is changing. Is that right @julielorch?

@joolaay
Copy link

joolaay commented Jul 10, 2014

nope - not changing. We just want a different title in the header for "What is DoSomething.org"

@sergiitk
Copy link
Contributor Author

@barryclark What I'm worried about is node id.
I don't know how international setup were init. If the starting point for these is DS production, it will work. If these were built from scratch (ds build --install), node id will change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently nid is hardcoded: node/538.

@barryclark
Copy link
Contributor

@sergii-tkachenko Thoughts on using a link to "about/who-we-are" instead of the node id?

@barryclark
Copy link
Contributor

Meh, actually that's a crappy idea, as if we changed the node's alias the link would be dead.

@sergiitk
Copy link
Contributor Author

@barryclark exactly. Plus, non-english sites may want to have aliases in its language.

@aaronschachter
Copy link
Contributor

No menus should be hardcoded with node nid's, we should use variables similar to what we use for the footer....

@sergiitk
Copy link
Contributor Author

@barryclark But so is ugly hardcoding a nid.
Moreover, I'd suggest using uuid module.

@angaither
Copy link
Contributor

@sergii-tkachenko uuid is installed :)

@sergiitk
Copy link
Contributor Author

Thank you for pointing that out, @angaither!
It turned out I accidentally put ignored html/profiles/dosomething/modules/ in my SublimeText.

@sergiitk
Copy link
Contributor Author

I'm thinking to use uuid_entity_autocomplete module.
Since we have a lot of nids hardcoded in the templates and anyway will replace these for i18n project, it'd may make sense to provide nice UI for selecting a node.

@angaither
Copy link
Contributor

this looks ok! 👍
I don't feel great about that uuid module, it doesn't seem to be supported or widely used

@sergiitk
Copy link
Contributor Author

@angaither I agree with you, but I'd like to have a little experiment with the module before throwing it out.
I'll merge what we have now and get back to you after the experiment.

sergiitk pushed a commit that referenced this pull request Jul 10, 2014
I18N: Make "What is DoSomething.org?" editable.
@sergiitk sergiitk merged commit f21843d into DoSomethingArchive:dev Jul 10, 2014
@sergiitk
Copy link
Contributor Author

@angaither, you were right, this uuid_entity_autocomplete module was rubbish. After selecting a node in the dropdown it just replaces input a node title with meaningless UUID.

@sergiitk
Copy link
Contributor Author

@angaither But take a look at the Entity Autocomplete. It's 2,362 sites using this module / 17,851 downloads.

Here's how selection works (It is already limited to Static Content pages only):
image
With page selected:
image

And compare to current look and UI:
image

I've saved a patch from my experiment and it'd take just a minute to commit it.
@angaither @julielorch @barryclark Should I go for it?

@sergiitk sergiitk deleted the editable-about-block branch July 10, 2014 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

5 participants