This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Editor user edit#2832
Merged
aaronschachter merged 4 commits intoDoSomethingArchive:devfrom Jul 15, 2014
aaronschachter:editor_user_edit
Merged
Editor user edit#2832aaronschachter merged 4 commits intoDoSomethingArchive:devfrom aaronschachter:editor_user_edit
aaronschachter merged 4 commits intoDoSomethingArchive:devfrom
aaronschachter:editor_user_edit
Conversation
…er profile fields
…_info_form values
Contributor
There was a problem hiding this comment.
Might be nice to make this a dropdown using the addressfield list of 'administrative area' choices if it's easy to do
Contributor
Author
There was a problem hiding this comment.
Yeah, I had trouble finding it in the addressfield code. Figured this was an easy way to at least get functionality in, and could always add back in.
Contributor
There was a problem hiding this comment.
Might be worth a shot to use the custom address field that's being used on the signup forms?
That way the validation would happen already as well
Contributor
|
Anyways, the code is all fine 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@angaither Can you please review?
Overview
Closes https://jira.dosomething.org/browse/DOS-58
Closes https://jira.dosomething.org/browse/DOS-59
user/*/infodosomething_user_form_alter, because the only way an editor could even access theuser/*/editform would be to grant permission toadminister users-- which also allows them to delete users if they went to the URL directly.form_alteras we add new ones.Screenshots