This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Campaign fixture images#2901
Merged
DFurnes merged 5 commits intoDoSomethingArchive:devfrom Jul 29, 2014
DFurnes:campaign-fixture-images
Merged
Campaign fixture images#2901DFurnes merged 5 commits intoDoSomethingArchive:devfrom DFurnes:campaign-fixture-images
DFurnes merged 5 commits intoDoSomethingArchive:devfrom
DFurnes:campaign-fixture-images
Conversation
tests/fixtures/campaign.json
Outdated
Contributor
There was a problem hiding this comment.
will this path work on stage & QA?
Contributor
There was a problem hiding this comment.
I think it should be ok on stage, but QA is not a vagrant box.
Can the paths be relative?
Contributor
Author
There was a problem hiding this comment.
Let me play around with it. It would definitely make more sense if they were relative to html/...
Contributor
There was a problem hiding this comment.
If there was a hardcoded path liek http://flickr.com/whatever this could be an easy solution too.... but then relies on that image always living there
Contributor
|
|
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds 📷s to campaign test node via JSON. Closes FT-20.
For review: @angaither @aaronschachter
Screenshot
It's starting to look like a real campaign!
