This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Taxonomy gallery show more#3505
Merged
weerd merged 4 commits intoDoSomethingArchive:devfrom Nov 20, 2014
weerd:taxonomy-gallery-show-more
Merged
Taxonomy gallery show more#3505weerd merged 4 commits intoDoSomethingArchive:devfrom weerd:taxonomy-gallery-show-more
weerd merged 4 commits intoDoSomethingArchive:devfrom
weerd:taxonomy-gallery-show-more
Conversation
Contributor
There was a problem hiding this comment.
If we wanna get picky picky, this Show More should be translated for our pals in Congo.
Contributor
Author
There was a problem hiding this comment.
Hmmm, ok. Will try it!
Contributor
|
Looks great! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the "greater than 5 campaigns" show more issue in ##3265. This provides a new JS object where you can pass a container element, a collection of 1 or more items inside container and it will hide them, and then show them via a "Show More" button.
This also will work smoothly if there happens to be more than one mosaic gallery on a page and hide extra items on all of the galleries. @mikefantini said it's highly unlikely, something like 0.00001%, but that means there's still A CHANCE!
@DFurnes
CC: @barryclark @aaronschachter @sbsmith86