Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Add tag as array#3508

Merged
deezone merged 3 commits intoDoSomethingArchive:devfrom
deezone:Issue3507-Missing_campaign_transational_tag
Nov 21, 2014
Merged

Add tag as array#3508
deezone merged 3 commits intoDoSomethingArchive:devfrom
deezone:Issue3507-Missing_campaign_transational_tag

Conversation

@deezone
Copy link
Contributor

@deezone deezone commented Nov 21, 2014

Fixes #3507

  • campaign_signup transactional email messages were missing additional message tags. The last tag addition was overwriting previous tags as it needed to be added as an array item.
  • Also fixes admin path to point to config page

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be kept in the dosomething menu group to keep all of our custom admin pages in the same place. (See #2527 and #3362) Please update the .info path instead.

@aaronschachter
Copy link
Contributor

Bug fix looks fine, pls just keep the menu path as is per comment.

@aaronschachter
Copy link
Contributor

👍

deezone pushed a commit that referenced this pull request Nov 21, 2014
@deezone deezone merged commit 8d6f2cd into DoSomethingArchive:dev Nov 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Campaign transactional email missing additional tags

2 participants