Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

ReportbackFile Entity#3608

Merged
aaronschachter merged 2 commits intoDoSomethingArchive:devfrom
aaronschachter:rb_file_entity
Dec 9, 2014
Merged

ReportbackFile Entity#3608
aaronschachter merged 2 commits intoDoSomethingArchive:devfrom
aaronschachter:rb_file_entity

Conversation

@aaronschachter
Copy link
Contributor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean is_null() or !empty()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah, i'm checking for is_null. change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you want also meant a case when $entity = FALSE because FALSE == NULL:

php > var_dump(FALSE == NULL);
bool(true)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehh, I mean.. i'm ok to leave it :) I'm specifically passing NULL as the argument for the $entity in dosomething_reportback_menu. and then Nodes and Taxonomy Terms for the other callbacks where this function is called.

@sergiitk
Copy link
Contributor

sergiitk commented Dec 9, 2014

👍

aaronschachter added a commit that referenced this pull request Dec 9, 2014
@aaronschachter aaronschachter merged commit 11d6d44 into DoSomethingArchive:dev Dec 9, 2014
@aaronschachter aaronschachter deleted the rb_file_entity branch December 9, 2014 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants