This repository was archived by the owner on Oct 29, 2020. It is now read-only.
waiting for image to load for mobile. fixes #3803#3807
Merged
sbsmith86 merged 1 commit intoDoSomethingArchive:devfrom Jan 27, 2015
Merged
waiting for image to load for mobile. fixes #3803#3807sbsmith86 merged 1 commit intoDoSomethingArchive:devfrom
sbsmith86 merged 1 commit intoDoSomethingArchive:devfrom
Conversation
Contributor
|
👍 |
sbsmith86
added a commit
that referenced
this pull request
Jan 27, 2015
waiting for image to load for mobile. fixes #3803
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
On mobile, when the validation ran the image had not yet been loaded and so the function thought that the dimension of the image was 0x0, causing an error to be thrown that the image was not large enough.
Changes
This PR creates an image object from the file reader result and then waits for it to load using
image.onload = function() {}. It then refactors the code a bit so that we pass the image created to various functions instead of the file reader result object.@DoSomething/front-end